-
Notifications
You must be signed in to change notification settings - Fork 41
Better CI workflow with Permissions check as a short circuit #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you can merge when you're satisfied.
|
Now all we need is an outsider to push a test PR to verify that that doesn't run the tests. @bmerkle ? |
|
Will do the test with the move of Tests to new directory in next PR once i am Home in a few hours..... Happy new year to you all 😃🍀👋🎉 |
|
ok PR #144 landed. @gvanrossum |
|
The 3rd party experience is better, they get one failure of a job named permissions. (After an owner approves it.) But as a project owner I still see 12 deployment approval emails?! |
|
We could reduce this to 4 by moving the check + format steps to their own jobs within the CI.
Another option would be to update the "online" tests to only run for a specific Python version which would take it down to 1. In the other cases we could do offline tests only.
Here's a draft PR for what the 1st option would look like: Moved Format and Check to their own jobs to reduce mail notifications for deployment approval by robgruen · Pull Request #148 · microsoft/typeagent-py<#148>
…________________________________
From: Guido van Rossum ***@***.***>
Sent: Thursday, January 1, 2026 6:42 AM
To: microsoft/typeagent-py ***@***.***>
Cc: Robert Gruen ***@***.***>; State change ***@***.***>
Subject: Re: [microsoft/typeagent-py] Better CI workflow with Permissions check as a short circuit (PR #143)
[https://avatars.githubusercontent.com/u/2894642?s=20&v=4]gvanrossum left a comment (microsoft/typeagent-py#143)<#143 (comment)>
The 3rd party experience is better, they get one failure of a job named permissions. (After an owner approves it.)
But as a project owner I still see 12 deployment approval emails?!
—
Reply to this email directly, view it on GitHub<#143 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGBS6WPJSAMENV6N72TSMAT4EUW5PAVCNFSM6AAAAACQNQWM3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBTG44DKOJZGU>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
No description provided.