-
Notifications
You must be signed in to change notification settings - Fork 41
Make pyright error on unused variables and imports #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This found a bug in answers.py: if N answers present, we'd add N copies of each of the generated answers
|
The 'make format' failures are spurious -- I don't know what causes them (maybe black version skew?) and they don't happen on my Mac. The change looks harmless and not something that should trigger a reformat. @robgruen this is ready for your review now. |
No they weren't. There was a formatting issue in tools/get_keys.py due to the added warning -- black wants it formatted like this: self.credential = (
DefaultAzureCredential()
) # CodeQL [SM05139] - This code is used as part of development setup only.I'm not sure if CodeQL is smart enough to honor that. Instead we should probably add |
|
I agree with you about CodeQL I'll make that change. |
I used AI (mostly Claude Opus 4.5) for this but reviewed everything it did and occasionally tweaked it (this is how I found the double loop in answers.py).