Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/heft-vscode-extension-plugin",
"comment": "add extraPackagingFlags plugin option",
"type": "patch"
}
],
"packageName": "@rushstack/heft-vscode-extension-plugin"
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ interface IVSCodeExtensionPackagePluginOptions {
* This manifest is used for signing the VS Code extension.
*/
manifestPath: string;
/**
* Additional flags to pass to the VSCE packaging command.
*/
extraPackagingFlags?: string[];
}

const PLUGIN_NAME: 'vscode-extension-package-plugin' = 'vscode-extension-package-plugin';
Expand All @@ -41,7 +45,7 @@ export default class VSCodeExtensionPackagePlugin
pluginOptions: IVSCodeExtensionPackagePluginOptions
): void {
heftTaskSession.hooks.run.tapPromise(PLUGIN_NAME, async (runOptions: IHeftTaskRunHookOptions) => {
const { unpackedFolderPath, vsixPath, manifestPath } = pluginOptions;
const { unpackedFolderPath, vsixPath, manifestPath, extraPackagingFlags = [] } = pluginOptions;
const { buildFolderPath } = heftConfiguration;
const {
logger: { terminal }
Expand All @@ -53,7 +57,14 @@ export default class VSCodeExtensionPackagePlugin
const packageResult: IWaitForExitResult<string> = await executeAndWaitAsync(
terminal,
'node',
[vsceScriptPath, 'package', '--no-dependencies', '--out', path.resolve(vsixPath)],
[
vsceScriptPath,
'package',
'--no-dependencies',
'--out',
path.resolve(vsixPath),
...extraPackagingFlags
],
{
currentWorkingDirectory: path.resolve(buildFolderPath, unpackedFolderPath)
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/heft/v0/heft.schema.json",

"extends": "@rushstack/heft-vscode-extension-rig/profiles/default/config/heft.json"
"extends": "@rushstack/heft-vscode-extension-rig/profiles/default/config/heft.json",

"phasesByName": {
"build": {
"tasksByName": {
"package-vsix": {
"taskPlugin": {
"options": {
"extraPackagingFlags": ["--allow-star-activation"]
}
}
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "debug-certificate-manager",
"version": "0.0.3",
"version": "0.0.4",
"repository": {
"type": "git",
"url": "https://github.com/microsoft/rushstack.git",
Expand Down Expand Up @@ -54,7 +54,7 @@
},
{
"command": "debugCertificateManager.sync",
"title": "Sync TLS Certificates",
"title": "Ensure and Sync TLS Certificates",
"category": "Debug Certificate Manager"
},
{
Expand Down Expand Up @@ -107,7 +107,7 @@
},
"enabledApiProposals": [],
"activationEvents": [
"workspaceContains:/.vscode/debug-certificate-manager.json"
"*"
],
"dependencies": {
"@rushstack/debug-certificate-manager": "workspace:*",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,6 @@ export function activate(context: vscode.ExtensionContext): void {
keyFilename: parsedConfig.keyFilename || 'rushstack-serve.key'
};
} catch (error) {
void vscode.window.showErrorMessage(
'Failed to read or parse the configuration file. Ensure that .vscode/debug-certificate-manager.json exists and is valid.'
);
terminal.writeLine(
`Error reading or parsing configuration file: ${
error instanceof Error ? error.message : 'Unknown error'
Expand Down
Loading