[debug-certificate-manager] update activation events #5334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for debug certificate manager extension activation event timing out
Details
Extension host logs:
We provided a very specific path in the workspaceContains activation event but the extension host still times out when looking for the file.
The timeout in VS Code not configurable. It is hardcoded to 7 seconds.
https://github.com/microsoft/vscode/blob/050422ff10abc7ccf088f003ab5843761ae4fcbf/src/vs/workbench/services/extensions/common/workspaceContains.ts#L18
This change updates the extension manifest to always activate the extension. It also removes the error dialog that renders if
.vscode/debug-certificate-manager.jsonfile is not found in the workspace to make the extension less noisy when opening workspaces without that config file.This bug repros consistently when a new codespace is created and vscode is waiting for it to boot up, run the post start scripts and attach. After the codespace is ready, the repro is flaky.
How it was tested
Tested that the extension unconditionally activates and we no longer get the extension host timeout.