[rush] Fix version bump removing policy fields#5309
Merged
dmichon-msft merged 2 commits intomicrosoft:mainfrom Aug 20, 2025
Merged
[rush] Fix version bump removing policy fields#5309dmichon-msft merged 2 commits intomicrosoft:mainfrom
dmichon-msft merged 2 commits intomicrosoft:mainfrom
Conversation
dmichon-msft
requested review from
D4N14L,
apostolisms and
octogonz
as code owners
D4N14L
approved these changes
Aug 19, 2025
iclanton
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the fields
dependencies,exemptFromRushChangeandincludeEmailInChangeFilewere discarded fromversion-policies.jsonduringrush version --bumpor similar commands.Details
The version bump logic asked for a fresh serialization of the data in the version policies, and the serializer was missing fields.
The revised logic has the version policy track the original JSON and modify it in place so that the
version-policies.jsonfile will only have the necessary changes.How it was tested
Ran
rush version --bumpin the rushstack repository after addingexemptFromRushChange: trueandincludeEmailInChangeFile: trueto the Rush version policy. Verified that in the old version these fields were discarded and in the new version they were preserved.Impacted documentation
Documentation is now correct, since it was neither stated nor implied that fields would be discarded during version bump.