Skip to content

[rush-bridge-cache] Ensure that Rush waits for the cache operation to finish #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 1 commit into from
Aug 7, 2025
Merged

[rush-bridge-cache] Ensure that Rush waits for the cache operation to finish #5300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/bridge-cache-fix-wait_2025-08-06-20-42.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix a bug in \"@rushstack/rush-bridge-cache-plugin\" where the cache replay did not block the normal execution process and instead was a floating promise.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
8 changes: 4 additions & 4 deletions rush-plugins/rush-bridge-cache-plugin/src/BridgeCachePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class BridgeCachePlugin implements IRushPlugin {
}
);
// populate the cache for each operation
command.hooks.beforeExecuteOperations.tap(
command.hooks.beforeExecuteOperations.tapPromise(
PLUGIN_NAME,
async (
recordByOperation: Map<Operation, IOperationExecutionResult>,
Expand Down Expand Up @@ -137,9 +137,9 @@ export class BridgeCachePlugin implements IRushPlugin {
const projectFolder: string = operation.associatedProject?.projectFolder;
const missingFolders: string[] = [];
operation.settings.outputFolderNames.forEach((outputFolderName: string) => {
if (!FileSystem.exists(`${projectFolder}/${outputFolderName}`)) {
missingFolders.push(outputFolderName);
}
if (!FileSystem.exists(`${projectFolder}/${outputFolderName}`)) {
missingFolders.push(outputFolderName);
}
});
if (missingFolders.length > 0) {
terminal.writeWarningLine(
Expand Down
Loading