[rush-bridge-cache] Ensure that Rush waits for the cache operation to finish#5300
Merged
iclanton merged 1 commit intomicrosoft:mainfrom Aug 7, 2025
Merged
Conversation
iclanton
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where Rush would finish executing but the bridge-cache plugin's work would continue as a floating promise.
Details
Incorrect tap action was used for an async function.
How it was tested
Temporarily linked in the plugin to rushstack and ran
rush build --bridge-cache-action=read. Verified that normal Rush logging for action completion occurs after the cache unpack finishes.Impacted documentation
None