-
Notifications
You must be signed in to change notification settings - Fork 667
[@rushstack/heft-config-file] Replace node structuredClone #5206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
octogonz
merged 3 commits into
microsoft:main
from
sherlockfeng:chore/replace-node-structuredclone
Apr 24, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
...nges/@rushstack/heft-config-file/chore-replace-node-structuredclone_2025-04-24-03-50.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/heft-config-file", | ||
| "comment": "Fix Node 16 compatibility by using non-built-in structuredClone", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/heft-config-file" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 16 additions & 13 deletions
29
common/config/subspaces/build-tests-subspace/pnpm-lock.yaml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "d9e805ea30f80e290b5d5ea83856c8b5d7302941", | ||
| "pnpmShrinkwrapHash": "e47112c7d099f189f37770e10351e406cf1ec451", | ||
| "preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68", | ||
| "packageJsonInjectedDependenciesHash": "949bb6038c34cb0580b82a6f728b26a66fff3177" | ||
| "packageJsonInjectedDependenciesHash": "a1277b20787fa46cb118a7352d5ca6a922a1098b" | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "1cd4f5444a9d6a085d5418372291de283264d9fb", | ||
| "pnpmShrinkwrapHash": "cff3c4ef9a27a2377b9fb1f907c5441b3996d5fb", | ||
| "preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to support Node 16 reliably, Rush needs to re-add CI validation for this environment. As discussed with @D4N14L it is not necessary for the entire Rush Stack monorepo to build with Node 16 (which will encounter a
typescript-eslintincompatibility). Instead, we could add a YAML step to the GitHub Action which merely invokes some Rush tests using Node 16 after building using the latest Node.@sherlockfeng will consider implementing this, after evaluating the importance of Node 16 for his case.