[@rushstack/heft-config-file] Replace node structuredClone#5206
Merged
octogonz merged 3 commits intomicrosoft:mainfrom Apr 24, 2025
Merged
[@rushstack/heft-config-file] Replace node structuredClone#5206octogonz merged 3 commits intomicrosoft:mainfrom
octogonz merged 3 commits intomicrosoft:mainfrom
Conversation
sherlockfeng
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton,
octogonz and
patmill
as code owners
D4N14L
approved these changes
Apr 24, 2025
...changes/@rushstack/heft-config-file/chore-replace-node-structuredclone_2025-04-24-03-50.json
Outdated
Show resolved
Hide resolved
…structuredclone_2025-04-24-03-50.json Co-authored-by: Daniel <3473356+D4N14L@users.noreply.github.com>
sherlockfeng
force-pushed
the
chore/replace-node-structuredclone
branch
from
1d4aa03 to
e4b3065
Compare
D4N14L
approved these changes
Apr 24, 2025
octogonz
reviewed
Apr 24, 2025
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/heft-config-file", | ||
| "comment": "Fix Node 16 compatibility by using non-built-in structuredClone", |
Collaborator
There was a problem hiding this comment.
If we want to support Node 16 reliably, Rush needs to re-add CI validation for this environment. As discussed with @D4N14L it is not necessary for the entire Rush Stack monorepo to build with Node 16 (which will encounter a typescript-eslint incompatibility). Instead, we could add a YAML step to the GitHub Action which merely invokes some Rush tests using Node 16 after building using the latest Node.
@sherlockfeng will consider implementing this, after evaluating the importance of Node 16 for his case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Replace the native
structuredClonewith@ungap/structured-clone.In this way, Rush can still run in the Node 16 environment.