Skip to content

Don't clear selected log entry in structured logs if filters are removed #15825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −2
Draft

Don't clear selected log entry in structured logs if filters are removed #15825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b72c689
Initial plan
Copilot Apr 2, 2026
44e7bde
Don't clear selected entry when filters are removed in structured log…
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Aspire.Dashboard/Components/Pages/Resources.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,15 @@ private async Task HandleSearchFilterChangedAsync()
private async Task VisibleResourcesChangedAsync()
{
await UpdateResourceGraphResourcesAsync();
await ClearSelectedResourceAsync();

// Only clear the selected resource if it no longer passes the current filter.
// This preserves the selection when a filter is removed (result set expands) and
// the selected resource is still visible.
if (SelectedResource is null || !Filter(SelectedResource))
{
await ClearSelectedResourceAsync();
}

await _dataGrid.SafeRefreshDataAsync();
}

Expand Down
9 changes: 8 additions & 1 deletion src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,14 @@ private async Task HandleSelectedLogLevelChangedAsync()
{
_resourceChanged = true;

await ClearSelectedLogEntryAsync();
// Only clear the selected log entry if a log level filter is being applied.
// If the log level is set to "All" (null), the filter is being removed and the
// selected entry is necessarily still in the results.
if (PageViewModel.SelectedLogLevel.Id is not null)
{
await ClearSelectedLogEntryAsync();
}

await this.AfterViewModelChangedAsync(_contentLayout, waitToApplyMobileChange: true);
}

Expand Down