Don't clear selected log entry in structured logs if filters are removed#15825
Draft
Don't clear selected log entry in structured logs if filters are removed#15825
Conversation
…s and resources pages Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/dd8ac091-5148-4ce3-afd3-0ea1bf1ff747 Co-authored-by: maddymontaquila <12660687+maddymontaquila@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix clearing selection of log entry when filters are removed
Don't clear selected log entry in structured logs if filters are removed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing the selected entry on any filter change was overly aggressive — removing a filter can only expand the result set, so the current selection is always still valid in that case.
Changes
StructuredLogs.razor.cs—HandleSelectedLogLevelChangedAsync: SkipClearSelectedLogEntryAsyncwhen the log level is reset to "All" (null). Only clear when a restrictive level filter is applied.Resources.razor.cs—VisibleResourcesChangedAsync: Replace the unconditionalClearSelectedResourceAsync()call with a check against the existingFilter()predicate. The selection is only cleared when the selected resource no longer passes the active filters. This covers all filter variants (type, state, health state, text search) correctly in both directions — a removed filter preserves selection, an added filter that excludes the selection still clears it.Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.com/usr/share/dotnet/dotnet dotnet test tests/Aspire.Dashboard.Components.Tests/Aspire.Dashboard.Components.Tests.csproj -- --filter-not-trait quarantined=true --filter-not-trait outerloop=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: