Modernize MSBuild configuration

.github/workflows/CI.yml

@@ -18,30 +18,34 @@ jobs:
     env:
       DOTNET_NOLOGO: true
 
+      # Pre-define global MSBuild properties
+      Configuration: Debug
+      # Ensure versioning is forced to a non-production version for CI builds
+      VersionSuffix: ${{ github.event_name == 'pull_request' && 'pr' || 'ci' }}
+
     steps:
     - uses: actions/checkout@v4
       with:
         lfs: true
 
     - uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: |
-          8.0.x
+        # dotnet-version: '8.0.x'
+        global-json-file: 'global.json'
 
     - run: dotnet --info
 
-    - name: Build (win)
-      run: ./build ci
-      shell: cmd
-      if: ${{ runner.os == 'Windows' }}
+    - name: Build PASopa.sln
+      run: dotnet build src/PASopa.sln
 
-      ## Only difference here is not forcing cmd
-    - name: Build (linux based)
-      run: ./build ci
-      if: ${{ runner.os != 'Windows' }}
+    # Pack so we can validate there are no warnings/errors
+    # We must explicitly set the configuration parameter otherwise it defaults to Release
+    - name: Pack - Formulas.Tools
+      run: dotnet pack --no-build -c ${{ env.Configuration }} src/PAModel/Microsoft.PowerPlatform.Formulas.Tools.csproj
 
-    - name: Test - Persistence
-      run: dotnet bin/Debug/Persistence.Tests/Persistence.Tests.dll
+    - name: Pack - Persistence
+      run: dotnet pack --no-build -c ${{ env.Configuration }} src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj
 
-    - name: Test - PAModel
-      run: dotnet bin/Debug/PAModelTests/PAModelTests.dll
+    # Run tests
+    - name: Test - PASopa.sln
+      run: dotnet test --no-build src/PASopa.sln

Directory.Build.props

@@ -0,0 +1,48 @@
+<Project>
+    <!-- See: https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2019#directorybuildprops-and-directorybuildtargets -->
+    <!-- The top of the repo should not import Directory.Build.* above it's structure -->
+    <!-- At the root of the repo, it's best to only include repo-wide settings and defaults. -->
+    <PropertyGroup Label="Repository Paths">
+        <RepoRoot>$(MSBuildThisFileDirectory)</RepoRoot>
+        <SrcPath>$([MSBuild]::NormalizeDirectory($(RepoRoot), 'src'))</SrcPath>
+        <RepoBinRoot>$([MSBuild]::NormalizeDirectory($(RepoRoot), 'bin'))</RepoBinRoot>
+        <RepoIntermediateRoot>$([MSBuild]::NormalizeDirectory($(RepoRoot), 'obj'))</RepoIntermediateRoot>
+
+        <!-- This file only exists during an official pipeline build -->
+        <PipelineVersionAssemblyInfoFilePath>$([MSBuild]::NormalizePath($(RepoRoot), '.version', 'PipelineAssemblyInfo.cs'))</PipelineVersionAssemblyInfoFilePath>
+    </PropertyGroup>
+
+    <PropertyGroup Label="Project defaults and output paths">
+        <!-- If not otherwise specified, the project is building for Debug.
+         This allows us to compose custom output paths based on configuration below.
+         -->
+        <Configuration>Debug</Configuration>
+
+        <!-- Signing defaults: -->
+        <AssemblyOriginatorKeyFile>$(RepoRoot)35MSSharedLib1024.snk</AssemblyOriginatorKeyFile>
+    </PropertyGroup>
+
+    <PropertyGroup Label="Nuget Config">
+        <RestorePackagesPath>$([MSBuild]::NormalizeDirectory($(RepoRoot), 'pkg'))</RestorePackagesPath>
+        <!-- <RestoreIgnoreFailedSource>true</RestoreIgnoreFailedSource> -->
+        <!-- <RestoreOutputPath>$(BaseIntermediateOutputPath)</RestoreOutputPath> -->
+    </PropertyGroup>
+
+    <PropertyGroup Label="Code Analysis config">
+        <!-- Without this, some code styling rules only execute in VS IDE, sometimes, only when the file is open -->
+        <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+        <EnableNETAnalyzers>true</EnableNETAnalyzers>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+        <CodeAnalysisTreatWarningsAsErrors>true</CodeAnalysisTreatWarningsAsErrors>
+    </PropertyGroup>
+
+    <!--
+    When building in VS IDE, we don't want to treat warnings as errors, because they randomize developer progress.
+    Warnings will be treated as errors at command line and in build pipelines
+    -->
+    <PropertyGroup Label="Code Analysis config for VS IDE"
+                   Condition="'$(BuildingInsideVisualStudio)' == 'true'">
+        <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+        <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
+    </PropertyGroup>
+</Project>

Directory.Build.targets

@@ -0,0 +1,10 @@
+<Project>
+    <!-- See: https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2019#directorybuildprops-and-directorybuildtargets -->
+    <!-- The top of the repo should not import Directory.Build.* above it's structure -->
+
+  <ItemGroup Label="Add signing keys for InternalsVisibleTo attributes">
+    <InternalsVisibleTo Update="@(InternalsVisibleTo->WithMetadataValue('Key', ''))"
+                        Key="0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9"
+                        />
+  </ItemGroup>
+</Project>