Modernize MSBuild configuration #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joem-msft
changed the title
joem-msft
force-pushed
the
users/joemay/fix-BA2004
branch
10 times, most recently
from
73e27b5 to
38475e0
Compare
- Enable `ManagePackageVersionsCentrally` - csproj should explicitly set `TargetFramework` or `TargetFrameworks` property - move `AssemblyOriginatorKeyFile` to root config - use dotnet cli instead of custom build script - use `dotnet test` to run test projects - use global-json-file to control dotnet version - Remove targets.csproj, as we should just recommend using dotnet locally - add tasks to build nuget packages during CI builds to validate any build errors or warnings during pack. - Make types/members `internal` now that `InternalsVisibleToAttribute` is being used for test projects. - standardize formatting of msbuild file indentations - Versioning is controlled using .Net SDK properties by default. Only in official build pipelines is `PipelineAssemblyInfo.cs` used
joem-msft
force-pushed
the
users/joemay/fix-BA2004
branch
from
38475e0 to
13c78c8
Compare
joem-msft
changed the title
tehcrashxor
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize MSBuild configuration
- Enable
ManagePackageVersionsCentrally- csproj should explicitly set
TargetFrameworkorTargetFrameworksproperty- move
AssemblyOriginatorKeyFileto root config- use dotnet cli instead of custom build script
- use
dotnet testto run test projects- use global-json-file to control dotnet version
- Remove targets.csproj, as we should just recommend using dotnet locally
- add tasks to build nuget packages during CI builds to validate any build errors or warnings during pack.
- Make types/members
internalnow thatInternalsVisibleToAttributeis being used for test projects.- standardize formatting of msbuild file indentations
- Versioning is controlled using .Net SDK properties by default. Only in official build pipelines is
PipelineAssemblyInfo.csused