Reduce usages of empty split() on literal strings#2438
Open
Avasam wants to merge 9 commits intomhammond:mainfrom
Open
Reduce usages of empty split() on literal strings#2438Avasam wants to merge 9 commits intomhammond:mainfrom
split() on literal strings#2438Avasam wants to merge 9 commits intomhammond:mainfrom
Conversation
Avasam
commented
Dec 14, 2024
Owner
|
I kinda like them - it's a feature imo - especially in demos or scripts where performance doesn't matter at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces useless overhead of calling
split, which also affects formatting consistency and readability.I also used the immutable
tuplewhere appropriate.