Cleanup com/win32com/test/testall.py#2514
Merged
Avasam merged 2 commits intomhammond:mainfrom Dec 10, 2025
Merged
Conversation
3eb60aa to
165c73a
Compare
165c73a to
c1efe12
Compare
…up-com.win32com.test.testall
mhammond
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing a few readability changes when debugging a failing test for #2502. But kept finding more and more to cleanup. So here it is all at once:
__file__-related codeGenerateAndRunOldStyle%printf-style formatTrueinsteadof1for booleanTrueimport_failuresto only contain the error instead of type + error instancesys.exc_info()make_test_suitenot using thetest_levelparameter0was a valid argumentAlso done in other PRs (so merging those first will reduce changes here):
listliterals instead of redundant call tostr.split()(also done in Reduce usages of emptysplit()on literal strings #2438)Given lots of tests don't run on the CI. This should be run locally.
Argument parsing behaviour change:
