Fix --skip-ignore-files to include .stylelintignore and all ignore parsers #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5 by dynamically identifying and skipping all ignore file parsers when using the
--skip-ignore-filesflag.Problem
The
--skip-ignore-filesflag was using a hardcoded list of parser names:This was missing
'stylelintignore'and would require manual updates for any future ignore file parsers.Solution
Replace the hardcoded list with dynamic filtering based on parser names ending with
'ignore':This now automatically skips all ignore file parsers:
gitignoredockerignoreeslintignoreprettierignorestylelintignoremarkdownlintignoresemgrepignorealexignoreChanges
src/cli.ts- Dynamic filtering logic with safety commentsREADME.md- Updated documentation to reflect all ignore files are skippedtests/integration/cli.test.ts- Added 2 new integration testsTest Coverage
Added two integration tests:
should skip ignore files with --skip-ignore-files- Tests all ignore files are skipped togethershould skip stylelintignore specifically with --skip-ignore-files- Specifically tests the reported bug caseAll 298 tests pass ✅
Benefits