Add support for 5 new ignore file parsers (Issue #5) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements feature request from #5 New ignore file parsers: - remarkignore (.remarkignore) - remark markdown processor - lycheeignore (.lycheeignore) - lychee link checker - secretlintignore (.secretlintignore) - secretlint - vscodeignore (.vscodeignore) - VS Code extensions - ignoresecrets (.ignoresecrets) - git-leaks alternative Changes: - Add 5 new ignore file parsers using the existing parseIgnoreFile function - Export new parsers from gitignore.ts and index.ts - Add new parsers to getBuiltinParsers() array - Update --skip-ignore-files to handle 'ignoresecrets' (doesn't end with 'ignore') - Update README.md to document new ignore files (67+ configs now supported) - Add comprehensive tests for all new parsers - Update CHANGELOG.md with both the fix and feature from #5 - Update integration tests to verify new ignore files are skipped with --skip-ignore-files All 303 tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the feature request part of #5 by adding support for 5 new ignore file parsers.
New Ignore File Parsers
This PR adds support for the following ignore files requested in #5:
.remarkignore- remark markdown processor ignore file.lycheeignore- lychee link checker ignore file.secretlintignore- secretlint ignore file.vscodeignore- VS Code extension ignore file.ignoresecrets- git-leaks alternative ignore fileAll use the standard gitignore format and reuse the existing
parseIgnoreFilefunction.Changes
src/parsers/gitignore.tssrc/parsers/index.tsgetBuiltinParsers()array--skip-ignore-filesto handle.ignoresecrets(special case: doesn't end with 'ignore')--skip-ignore-filesCHANGELOG Entry
The CHANGELOG.md now documents:
--skip-ignore-filesproperly skips.stylelintignore(PR Fix --skip-ignore-files to include .stylelintignore and all ignore parsers #6)Test Coverage
tests/parsers/gitignore.test.tsBefore & After
Before: 62+ configuration files
After: 67+ configuration files
Closes #5