fix(webapp): MCA-201 Resolve getServerSideProps Missing Return Object Error#1091
Draft
willgibson-madetech wants to merge 4 commits intomainfrom
Draft
fix(webapp): MCA-201 Resolve getServerSideProps Missing Return Object Error#1091willgibson-madetech wants to merge 4 commits intomainfrom
willgibson-madetech wants to merge 4 commits intomainfrom
Conversation
…appens in the Cypress tests
willgibson-madetech
temporarily deployed
to
ci-test
GitHub Actions
Inactive
willgibson-madetech
had a problem deploying
to
ci-test
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Aim to resolve https://madetech-team-b91dpvs1.atlassian.net/browse/MCA-201 and reduce log noise.
Changes in this pull request
given a non-existent currentUseIdtest, which was already not asserting what it said on the tinGuidance to review
This will need human testing to be sure we haven't changed the desired behaviour in some way that is not covered by automated tests.
Things to check