Quick pass at fixing bugs MCA-158 and MCA-201#1086
Closed
willgibson-madetech wants to merge 6 commits intomainfrom
Closed
Quick pass at fixing bugs MCA-158 and MCA-201#1086willgibson-madetech wants to merge 6 commits intomainfrom
willgibson-madetech wants to merge 6 commits intomainfrom
Conversation
| <PageContent> | ||
| <LegacyBeaconSummaryPanel | ||
| legacyBeaconId={beacon.id} | ||
| legacyBeaconId={beaconId} |
Contributor
Author
There was a problem hiding this comment.
The fix for MCA-158 Handle legacy Beacons with no Hex ID.
Contributor
Author
There was a problem hiding this comment.
Test created to demonstrate MCA-158 Handle legacy Beacons with no Hex ID before fixing it.
| return await rule.action(); | ||
| } | ||
| } | ||
| return { props: {} }; |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Test created to demonstrate MCA-201 Resolve getServerSideProps Missing Return Object Error before fixing it.
willgibson-madetech
temporarily deployed
to
ci-test
GitHub Actions
Inactive
willgibson-madetech
temporarily deployed
to
ci-test
GitHub Actions
Inactive
willgibson-madetech
temporarily deployed
to
ci-test
GitHub Actions
Inactive
Contributor
Author
|
Closing this as the work has been split into separate branches: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix these two bugs on our community of practice call: