⚡ Optimize Gem Addition Logic

modules/Gem/pom.xml

@@ -66,6 +66,10 @@
             <id>placeholderapi</id>
             <url>https://repo.extendedclip.com/content/repositories/placeholderapi/</url>
         </repository>
+        <repository>
+            <id>jitpack.io</id>
+            <url>https://jitpack.io</url>
+        </repository>
     </repositories>
 
     <dependencies>
@@ -76,10 +80,34 @@
             <scope>provided</scope>
         </dependency>
         <dependency>
-            <groupId>me.clip</groupId>
-            <artifactId>placeholderapi</artifactId>
+            <groupId>com.github.PlaceholderAPI</groupId>
+            <artifactId>PlaceholderAPI</artifactId>
             <version>2.11.1</version>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.13.2</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-inline</artifactId>
+            <version>5.2.0</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>net.bytebuddy</groupId>
+            <artifactId>byte-buddy</artifactId>
+            <version>1.14.17</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>net.bytebuddy</groupId>
+            <artifactId>byte-buddy-agent</artifactId>
+            <version>1.14.17</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 </project>

modules/Gem/src/main/java/com/mcatk/gem/GemExecutor.java

@@ -43,16 +43,7 @@ public Integer getTotalGems(String name) {
     }
 
     public void addGems(String name, int addGems) {
-        Integer gems = MySQLManager.getInstance().getGems(name);
-        if (MySQLManager.getInstance().getGems(name) == null) {
-            MySQLManager.getInstance().insertData(name);
-            gems = 0;
-        }
-        Integer total = MySQLManager.getInstance().getTotal(name);
-        gems += addGems;
-        total += addGems;
-        MySQLManager.getInstance().setGems(name, gems);
-        MySQLManager.getInstance().setTotal(name, total);
+        MySQLManager.getInstance().addGems(name, addGems);
         Gem.getPlugin().log(name + "获得宝石" + addGems);
     }
 }

modules/Gem/src/main/java/com/mcatk/gem/sql/MySQLManager.java

@@ -117,4 +117,20 @@ public void setTotal(String name, int num) {
         }
     }
 
+    public void addGems(String name, int amount) {
+        try (PreparedStatement ps = connection.prepareStatement(
+                "INSERT INTO `gem` (`username`, `gems`, `total`) VALUES (?, ?, ?) " +
+                        "ON DUPLICATE KEY UPDATE `gems` = `gems` + ?, `total` = `total` + ?"
+        )) {
+            ps.setString(1, name);
+            ps.setInt(2, amount);
+            ps.setInt(3, amount);
+            ps.setInt(4, amount);
+            ps.setInt(5, amount);
+            ps.executeUpdate();
+        } catch (SQLException e) {
+            e.printStackTrace();
+        }
+    }
+
 }

modules/Gem/src/test/java/com/mcatk/gem/GemExecutorTest.java

@@ -0,0 +1,69 @@
+package com.mcatk.gem;
+
+import com.mcatk.gem.sql.MySQLManager;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import java.lang.reflect.Field;
+
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.*;
+
+public class GemExecutorTest {
+
+    @Mock
+    private Gem gemMock;
+    @Mock
+    private MySQLManager mysqlManagerMock;
+
+    @Before
+    public void setUp() throws Exception {
+        MockitoAnnotations.openMocks(this);
+
+        // Mock Gem.plugin
+        Field pluginField = Gem.class.getDeclaredField("plugin");
+        pluginField.setAccessible(true);
+        pluginField.set(null, gemMock);
+
+        // Mock MySQLManager.instance
+        Field instanceField = MySQLManager.class.getDeclaredField("instance");
+        instanceField.setAccessible(true);
+        instanceField.set(null, mysqlManagerMock);
+    }
+
+    @After
+    public void tearDown() throws Exception {
+        // Reset static fields
+        Field pluginField = Gem.class.getDeclaredField("plugin");
+        pluginField.setAccessible(true);
+        pluginField.set(null, null);
+
+        Field instanceField = MySQLManager.class.getDeclaredField("instance");
+        instanceField.setAccessible(true);
+        instanceField.set(null, null);
+    }
+
+    @Test
+    public void testAddGems_InteractionCount() {
+        GemExecutor executor = new GemExecutor();
+        String name = "testUser";
+        int amount = 10;
+
+        // Execute
+        executor.addGems(name, amount);
+
+        // Verify interactions for the optimized path
+        verify(mysqlManagerMock, times(1)).addGems(eq(name), eq(amount));
+
+        // Ensure other methods are NOT called
+        verify(mysqlManagerMock, never()).getGems(anyString());
+        verify(mysqlManagerMock, never()).getTotal(anyString());
+        verify(mysqlManagerMock, never()).insertData(anyString());
+        verify(mysqlManagerMock, never()).setGems(anyString(), anyInt());
+        verify(mysqlManagerMock, never()).setTotal(anyString(), anyInt());
+    }
+}

modules/Gem/src/test/java/com/mcatk/gem/sql/MySQLManagerTest.java

@@ -0,0 +1,57 @@
+package com.mcatk.gem.sql;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import java.lang.reflect.Field;
+import java.sql.Connection;
+import java.sql.PreparedStatement;
+
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.*;
+
+public class MySQLManagerTest {
+
+    @Mock
+    private Connection connectionMock;
+    @Mock
+    private PreparedStatement preparedStatementMock;
+
+    @Before
+    public void setUp() throws Exception {
+        MockitoAnnotations.openMocks(this);
+    }
+
+    @Test
+    public void testAddGems_SQL() throws Exception {
+        MySQLManager manager = new MySQLManager();
+
+        // Inject mock connection
+        Field connectionField = MySQLManager.class.getDeclaredField("connection");
+        connectionField.setAccessible(true);
+        connectionField.set(manager, connectionMock);
+
+        when(connectionMock.prepareStatement(anyString())).thenReturn(preparedStatementMock);
+
+        String name = "user1";
+        int amount = 50;
+
+        manager.addGems(name, amount);
+
+        // Verify the SQL statement
+        String expectedSQL = "INSERT INTO `gem` (`username`, `gems`, `total`) VALUES (?, ?, ?) " +
+                "ON DUPLICATE KEY UPDATE `gems` = `gems` + ?, `total` = `total` + ?";
+        verify(connectionMock).prepareStatement(expectedSQL);
+
+        // Verify parameters
+        verify(preparedStatementMock).setString(1, name);
+        verify(preparedStatementMock).setInt(2, amount); // gems value
+        verify(preparedStatementMock).setInt(3, amount); // total value
+        verify(preparedStatementMock).setInt(4, amount); // increment gems
+        verify(preparedStatementMock).setInt(5, amount); // increment total
+
+        verify(preparedStatementMock).executeUpdate();
+    }
+}