β‘ Optimize Gem Addition Logic #5
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
GemExecutor.addGemsto use a newaddGemsmethod inMySQLManager.addGemsinMySQLManagerusingINSERT ... ON DUPLICATE KEY UPDATEto handle both new and existing users in a single query.GemExecutorTestandMySQLManagerTestto verify the fix and prevent regressions.pom.xmlto include test dependencies (junit,mockito-inline,byte-buddy) and fixPlaceholderAPIresolution.π― Why:
π Measured Improvement:
GemExecutorTestthat database interactions were reduced from ~5 calls to 1 call.MySQLManagerTestthat the generated SQL is correct and efficient.PR created automatically by Jules for task 1554755171763117530 started by @acsoto