fix: non-deterministic tests in export_upload_test#1270
Merged
jzimbel-mbta merged 2 commits intomasterfrom Aug 6, 2025
Merged
Conversation
Whoops
commented
Jun 12, 2025
| data = | ||
| ExportUpload.extract_data_from_upload( | ||
| %{path: "#{@export_dir}/#{export}"}, | ||
| "uid-#{System.unique_integer([:positive])}" |
Contributor
Author
There was a problem hiding this comment.
My first theory was that with the tests all writing to the same directory, maybe two different tests were clobbering each other's data. This didn't fix the problem, but I left it in since it seemed like good practice.
Contributor
Author
|
To replicate the failure locally, you can checkout master and run |
Contributor
Author
|
Here's a CI run that had the failure. |
Member
There was a problem hiding this comment.
Looks good, just leaving a "comment" review for now to get github slackbot to stop reminding about this PR until we get some input from Shanti on #1271 next week in two weeks.
jzimbel-mbta
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: NO TICKET
[Please include a brief description of what was changed]
Reviewer Checklist