Skip to content

Fix EOL detection at end of file without a trailing newline #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpoelstra wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix EOL detection at end of file without a trailing newline #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d33534
Fix EOL detection at end of file without a trailing newline
rpoelstra Jun 30, 2025
00c0417
Use `is_eof` property
rpoelstra Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pdfreader/parsers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def maybe_spaces_or_comments(self):

def eol(self):
""" EOL is either CR or LF or the both """
if self.current not in EOL:
if not self.is_eol:
self.on_parser_error("EOL expected")
self.maybe_eol()

Expand All @@ -88,7 +88,7 @@ def maybe_eol(self):

@property
def is_eol(self):
return self.current is not None and self.current in EOL
return self.is_eof or self.current in EOL

@property
def is_whitespace(self):
Expand Down