Fix EOL detection at end of file without a trailing newline#143
Open
rpoelstra wants to merge 2 commits intomaxpmaxp:masterfrom
Open
Fix EOL detection at end of file without a trailing newline#143rpoelstra wants to merge 2 commits intomaxpmaxp:masterfrom
rpoelstra wants to merge 2 commits intomaxpmaxp:masterfrom
Conversation
Owner
|
@rpoelstra can you share the document with me please? |
Author
|
Unfortunately, I can't share this document due to sensitive information inside the document. Redacting the document removes the tricky situation which pdfreader is unable to handle. But in essence this PR also treats EOF as EOL, which seems logical as a line cannot extend beyond the end of the document. |
Owner
|
@rpoelstra let me rephrase my question then. Does your file end with |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I've a PDF with a '%%EOF' comment that ends without a newline character. This caused a TypeError exception in comment() on line 187.
I've fixed this by including EOF (None) as a valid EOL marker.
If you accept this PR it would be great if you can make a new release also, so I can convert back to my normal workflow :)