Open
Conversation
Aksellence
approved these changes
Aug 28, 2020
Contributor
Aksellence
left a comment
Aksellence
left a comment
There was a problem hiding this comment.
Other than the few comments on the const, everything looks good.
| float full_charge_capacity_wh; | ||
| uint8_t status_flags; | ||
| uint32_t model_instance_id; | ||
| uint8_t model_name[32+1]; |
Contributor
There was a problem hiding this comment.
Can we have more insight into what does '32' and '1' stand for? We could define them as a const maybe?
|
|
||
| for (uint8_t i = 0; i < AP_UAVCAN_MAX_BI_NUMBER; i++) { | ||
| if (_bi_id[i] != id) { | ||
| if (id != -1 && _bi_id[i] != id) { |
Contributor
There was a problem hiding this comment.
It would be good to define -1 as a const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will let us associate a battery serial number with each flight in the ArduPilot log