Skip to content

Support empty response when use of 'opt.modified_since' #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qualbeen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support empty response when use of 'opt.modified_since' #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/runkeeper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ HealthGraph.prototype.apiCall = function(opts, callback) {
* If passed opts.get_next it will get all items of the activity feed until there is no more
* `data.next`.
*
* If passed opts.modified_since you might get an empty response (304 Not Modified). In those cases callback(null, []) will be called
*
* @param {Object} opts (Optional) Gets extended by `resources.fitnessActivityFeed`.
* @param {Function} callback Given err and data.
*/
Expand All @@ -157,6 +159,7 @@ HealthGraph.prototype.activityFeed = function(opts, callback) {

this.apiCall(opts, function(err, data) {
if (err) return callback(err, null);
if (!data.items) return callback(null, []);

if (data.next) {
opts.items = data.items.concat(opts.items);
Expand Down