Support empty response when use of 'opt.modified_since'#1
Open
qualbeen wants to merge 1 commit intomatiasdoyle:masterfrom
Open
Support empty response when use of 'opt.modified_since'#1qualbeen wants to merge 1 commit intomatiasdoyle:masterfrom
qualbeen wants to merge 1 commit intomatiasdoyle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this little line
client.activityFeed()won't work if you useopt.modified_sincetogether withopt.get_next.I'm not sure if passing an empty array to the callback is best practice, but it works well enough.
I believe this case should not trow an error, since "304 Not Modified" is a valid response!