Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

marksonseedify / solidity-challenge Public

forked from exactly/solidity-challenge

Notifications You must be signed in to change notification settings
Fork 2
Star 0

Code
Pull requests 1
Actions
Projects
Security and quality
Insights

Additional navigation options

Code
Pull requests
Actions
Projects
Security and quality
Insights

feat: challenge completed#1

Open

Theo6890 wants to merge 105 commits intomarksonseedify:mainmarksonseedify/solidity-challenge:mainfrom

Theo6890:theo-richardTheo6890/ETHPool-solidity-challenge:theo-richardCopy head branch name to clipboard

Conversation Commits105 (105)Checks Files changed

Open

feat: challenge completed#1
Theo6890 wants to merge 105 commits intomarksonseedify:mainfrom
Theo6890:theo-richard

Commits

Commits on Jan 12, 2023

chore: init repo with template
Theo6890
committed
docs: prettier on README
Theo6890
committed
chore: exclude foundry from prettier
Theo6890
committed
chore: delete `Token` contract from template
Theo6890
committed
feat: define `ETHPool` attributes according to doc
Theo6890
committed
feat: use `Address` library from OZ
Theo6890
committed
feat: make `ETHPool` inherit from `Ownable`
Theo6890
committed
test: file to test `ETHPool`
Theo6890
committed
test: default owner is the deployer
Theo6890
committed
refactor: re-order variables and add comments to cut sections
Theo6890
committed
test: create a file to set up common attributes for `ETHPool`
Theo6890
committed
refactor: `ETHPoolTest` only test `owner` with set up file
Theo6890
committed
feat: use a set to manage team members
Theo6890
committed
test: fixtures file for `Users` & `TeamMembers`
Theo6890
committed
feat: add team member with function call restriction
Theo6890
committed
test: add team member, restrictions & event emittance
Theo6890
committed
feat: getter `_teamMembers.length()`
Theo6890
committed
feat: getter `isTeamMember(...)`
Theo6890
committed
feat: remove a team member
Theo6890
committed
test: remove team member, restrictions & event emittance
Theo6890
committed
test: comment out Foundry's buggy tests
Theo6890
committed
chore: add `@nomicfoundation/hardhat-foundry` package
Theo6890
committed
chore: specify forge test path in .toml
Theo6890
committed
refactor: only use `msg.sender` in `canUpdateTeam`
Theo6890
committed
test: file to for `canUpdateTeam` testing with Hardhat
Theo6890
committed
test: unverified user can't add a team member
Theo6890
committed
test: unverified user can't remove a team member
Theo6890
committed
feat: require member absence/presence to update the set
Theo6890
committed
test(revert): when adding an existsing member
Theo6890
committed
test(revert): when removing non existent member
Theo6890
committed
refactor: rename modifier `canUpdateTeam`
Theo6890
committed
test: owner deposits rewards and RewardsDeposit emittance
Theo6890
committed
feat: deposit rewards logic from owner or team
Theo6890
committed
test(helper): wei & ether conversion
Theo6890
committed

Commits on Jan 13, 2023

test: verifies deposit data including UsersDeposit
Theo6890
committed
feat: implement deposit for dApp users
Theo6890
committed
refactor: group snapshot vars and update struct name
Theo6890
committed
refactor(test): variables names in depositRewards
Theo6890
committed
test: add test on snapshotDeposits value in depositRewards
Theo6890
committed
test(revert): userDeposit fails on DEPOSIT_ONCE_WEEK
Theo6890
committed
test: verifies users can deposit again after 1 week
Theo6890
committed
test: description of tests to add in depositRewards
Theo6890
committed
refactor: sperate contract `TeamManagement`
Theo6890
committed
refactor: separate contract for `Rewards`
Theo6890
committed
refactor: separate contract `UserData`
Theo6890
committed
feat: pending rewards
Theo6890
committed
refactor: rename SnapshotReward last parameter
Theo6890
committed
feat: get ether balance from using hardhat task
Theo6890
committed
test: pending rewards with multiple users
Theo6890
committed
chore: update deploy script with `ETHPool` contract
Theo6890
committed
chore: add goerli in apiKey
Theo6890
committed
chore: add address to verify in `verify.js`
Theo6890
committed
docs: update README.md with results
Theo6890
committed
chore: use ETHPool address to retrieve its ETH balance
Theo6890
committed
fix: prototype only for `pendingRewards` in Rewards
Theo6890
committed
fix: shadow declaration
Theo6890
committed
test: pending rewards withdrawl
Theo6890
committed
test: full withdrawl
Theo6890
committed
fix(test): deposited rewards
Theo6890
committed
fix: call to `withdrawPendingRewards`
Theo6890
committed
refactor: add withdraw logic into `UserData` contract
Theo6890
committed
fix: file naming
Theo6890
committed
refactor: nextWeek to nextDepositWeek
Theo6890
committed
refactor: oz Address library in `UserData`
Theo6890
committed
feat: withdraw pending rewards logic
Theo6890
committed
test: withdraw data, including UserWithdrawal(...)
Theo6890
committed
test(revert): fail on: NO_REWARDS_FOR_USER
Theo6890
committed
feat: revert when if user tries to withdraw 0 rewards
Theo6890
committed
test(revert): fails on `WITHDRAW_ONCE_WEEK`
Theo6890
committed
test: fails on `NO_REWARDS_DEPOSITED`
Theo6890
committed
feat(revert): pending rewards calculation if no user deposit
Theo6890
committed
feat(revert): if team deposit when no user deposits
Theo6890
committed
test(revert): if team deposit when no user deposits
Theo6890
committed
refactor: internal `_depositRewards`
Theo6890
committed
refactor: revert message `NO_USERS_DEPOSITS`
Theo6890
committed
refactor: single `_withdraw` function
Theo6890
committed
feat: withdrawAll
Theo6890
committed
test: withdrawAll including data and event
Theo6890
committed
refactor(docs): delete useless comments
Theo6890
committed
feat: team can deposit rewards only once a week
Theo6890
committed
test(revert): ails on `WEEKLY_REWARDS_DEPOSIT`
Theo6890
committed
fix: test name
Theo6890
committed
test(revert): fails on `Pool_OWNER_TEAM_ONLY`
Theo6890
committed
test(revert): fails on `DEPOSIT_REWARDS_ZERO`
Theo6890
committed
test(revert): fails on `USER_DEPOSIT_ZERO`
Theo6890
committed
refactor(docs): delete useless comment
Theo6890
committed
refactor: nextDepositWeek to `weekCounter`
Theo6890
committed
refactor: rename `snapshotDeposits`
Theo6890
committed
refactor: weekly rewards deposit restriction to internal function
Theo6890
committed
refactor(visibility): depositRewards `external`
Theo6890
committed
test: create a deposit helper
Theo6890
committed
refactor(withdraw): instanciate pool in `beforeEach`
Theo6890
committed
chore: getBalance helper
Theo6890
committed
refactor: withdrawAll to use helpers
Theo6890
committed
chore: helper to get pending rewards
Theo6890
committed
test(wthdrawAll): use pending rewards helper
Theo6890
committed
feat: reset deposit on withdrawAll and total counters
Theo6890
committed
test: verify deposit reset on withdrawAll + counters
Theo6890
committed
fix(helper): missing import
Theo6890
committed
refactor(withdraw): use created helpers
Theo6890
committed
test(withdraw): total counter updates on rewards withdrawls
Theo6890
committed
feat: update total counter on rewards withdrawls
Theo6890
committed
chore: add `solidity-coverage`
Theo6890
committed
chore: update `verify` script with latest deployed version
Theo6890
committed
docs: update `Results` section
Theo6890
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.