Skip to content

feat: challenge completed#1

Open
Theo6890 wants to merge 105 commits intomarksonseedify:mainfrom
Theo6890:theo-richard
Open

feat: challenge completed#1
Theo6890 wants to merge 105 commits intomarksonseedify:mainfrom
Theo6890:theo-richard

Conversation

@Theo6890
Copy link
Copy Markdown

There are some things that must be done, if such a contract would be used in production:

  • optimize pendingRewards and extensive testing as this is the critical logic part
  • fix totalRewards counter issues
  • more refactoring with more helpers
  • deeper testing: fuzz testing, specific edges cases, static analysers & write a document for test scenarios + code review on paper for critical points (pendingRewards)
  • break down the app in tasks and branches instead of working on a single branch in order to have the choice to revert a whole feature once merge in main

Notes: some config files have put outside project as it is not possible to do differently (.github, .husky...)

Using Forge it will always be 0xb4c79daB8f259C7Aee6E5b2Aa729821864227e84
Avoids member redundancy with an `EnumerableSet.AddressSet`
Only the owner or a team member can update team members
Counter starts at 1, which means first deposit is made at week 1
For getBalance and userDeposit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant