Open
Conversation
Using Forge it will always be 0xb4c79daB8f259C7Aee6E5b2Aa729821864227e84
Team variables first, then users
`ETHPoolTestSetUp`
Avoids member redundancy with an `EnumerableSet.AddressSet`
Only the owner or a team member can update team members
Counter starts at 1, which means first deposit is made at week 1
For getBalance and userDeposit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some things that must be done, if such a contract would be used in production:
pendingRewardsand extensive testing as this is the critical logic parttotalRewardscounter issuespendingRewards)mainNotes: some config files have put outside
projectas it is not possible to do differently (.github, .husky...)