Skip to content

repo for gem install xmlparser failure #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shayangz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

repo for gem install xmlparser failure #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:2.3-slim
FROM ubuntu:16.04

# some basic stuff
RUN mkdir /usr/src/app
Expand Down
2 changes: 2 additions & 0 deletions app/install_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@ if [ -z ${PACKAGES} ]; then
else
echo 'installing packages'
apt-get update
apt-get install -y ruby2.3 ruby2.3-dev
Copy link
Copy Markdown
Owner

@majormoses majormoses Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not going with using the ruby based docker images we might as well just pass these in via ENV vars so it could be used against multiple versions of ruby. I threw this together quickly.

IFS=',' read -ra INSTALL_PACKAGES <<< $PACKAGES
for i in "${INSTALL_PACKAGES[@]}"; do
echo $i
apt-get install -y $i
done
echo 'installing Gems'
gem install bundle
bundle install
echo 'listing installed packages:'
dpkg --get-selections
Expand Down