repo for gem install xmlparser failure#1
Open
shayangz wants to merge 1 commit intomajormoses:masterfrom
Open
Conversation
majormoses
requested changes
Jun 3, 2017
Owner
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
Let's also update README to reflect changes.
| else | ||
| echo 'installing packages' | ||
| apt-get update | ||
| apt-get install -y ruby2.3 ruby2.3-dev |
Owner
There was a problem hiding this comment.
If we are not going with using the ruby based docker images we might as well just pass these in via ENV vars so it could be used against multiple versions of ruby. I threw this together quickly.
Owner
|
Also there is still all of the stuff missing that was being done in rubny-slim such as setting up GEM_HOME. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the
ruby2.3-devpackage is the curlpit. I couldn't get the repro working with the2.3-slimimage so changed it toubuntu:16.04.