Skip to content

WINDUPRULE-955 added -rhr suffix and made second rule category mandatory #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipCattanach wants to merge 1 commit into
base: WINDUPRULE-955
Choose a base branch
from
Open

WINDUPRULE-955 added -rhr suffix and made second rule category mandatory #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...iewed/rhr/springboot/springboot.rhamt.xml → .../rhr/springboot/springboot-rhr.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<ruleset id="springboot" xmlns="http://windup.jboss.org/schema/jboss-ruleset"
<ruleset id="springboot-rhr" xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<metadata>
Expand All @@ -16,7 +16,7 @@
<targetTechnology id="rhr"/>
</metadata>
<rules>
<rule id="springboot-00001">
<rule id="springboot-rhr-00001">
<!-- rule condition, when it could be fired -->
<when>
<dependency groupId="org.springframework.boot" artifactId="{*}" toVersion="2.2.5.RELEASE" />
Expand All @@ -29,7 +29,7 @@
</hint>
</perform>
</rule>
<rule id="springboot-00002">
<rule id="springboot-rhr-00002">
<!-- rule condition, when it could be fired -->
<when>
<or>
Expand All @@ -47,7 +47,7 @@
</when>
<!-- rule operation, what to do if it is fired -->
<perform>
<hint title="Unsupported version of Spring Boot" effort="1" category-id="potential">
<hint title="Unsupported version of Spring Boot" effort="1" category-id="mandatory">
<message>Spring Boot has to be updated to a version supported by Red Hat Runtimes</message>
<link href="https://access.redhat.com/articles/3348731" title="RHOAR Component Details Overview" />
</hint>
Expand Down
6 changes: 3 additions & 3 deletions ...pringboot/tests/springboot.rhamt.test.xml → ...boot/tests/springboot-rhr.windup.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<testDataPath>data</testDataPath>
<rulePath>../springboot.rhamt.xml</rulePath>
<rulePath>../springboot-rhr.windup.xml</rulePath>
<ruleset>
<rules>
<rule id="springboot-00001-test">
<rule id="springboot-rhr-00001-test">
<when>
<not>
<iterable-filter size="18">
Expand All @@ -18,7 +18,7 @@
<fail message="[springboot-00001] Spring Boot update to v2.0 pre-migration hint was not found!" />
</perform>
</rule>
<rule id="springboot-00002-test">
<rule id="springboot-rhr-00002-test">
<when>
<not>
<iterable-filter size="4">
Expand Down