WINDUPRULE-955 added -rhr suffix and made second rule category mandatory#9
Open
PhilipCattanach wants to merge 1 commit intom-brophy:WINDUPRULE-955from
Open
Conversation
PhilipCattanach
added a commit
that referenced
this pull request
Jan 17, 2024
* WINDUPRULE-1041 Work in progress * Update jakarta-cdi-to-quarkus.windup.test.xml attempt to fix test failures * Winduprule 1041 (#9) * cgi to quarkus rules for jakarta classes * remove failing groovy tests --------- Co-authored-by: Phil Cattanach <pcattana@pcattana.remote.csb> Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mark,
This RHR ruleset is a complete ballsache to test as all of the springboot prefixed rules fire.
So I have renamed the ruleset from springboot.rhamt.xml to springboot-rhr.windup.xml, and reflected the changes in the rules and tests.
I have also changed the second rule from potential to mandatory.
If you are happy then please merge my PR into yours then I will merge yours to master.
Thanks,
Phil