Skip to content

Release/workflow #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lupodevelop merged 2 commits into from
Nov 9, 2025
Merged

Release/workflow #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a23c4
Release v1.0.0
lupodevelop Nov 9, 2025
eb48dc8
Automate confirmation for pre-1.0.0 Gleam publish
lupodevelop Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ jobs:
HEXPM_API_KEY: ${{ secrets.HEX_API_KEY }}
run: |
echo "Publishing package to Hex..."
gleam publish --yes
# For versions < 1.0.0, gleam publish requires explicit confirmation
# We pipe the required text to accept publishing 0.x versions
echo "I am not using semantic versioning" | gleam publish --yes
Comment on lines +106 to +108
Copy link

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment and piped input are intended for versions < 1.0.0, but the version in gleam.toml is being set to 1.0.0. This workflow change is unnecessary for 1.0.0 and later versions, as they follow semantic versioning and don't require the 'I am not using semantic versioning' confirmation. Either revert this workflow change or keep the version below 1.0.0.

Suggested change
# For versions < 1.0.0, gleam publish requires explicit confirmation
# We pipe the required text to accept publishing 0.x versions
echo "I am not using semantic versioning" | gleam publish --yes
gleam publish --yes

Copilot uses AI. Check for mistakes.

- name: Create GitHub Release
if: startsWith(github.ref, 'refs/tags/')
Expand Down
2 changes: 1 addition & 1 deletion gleam.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name = "sparkling"
version = "0.1.0"
version = "1.0.0"
description = "A fast, type-safe ClickHouse client for Gleam with composable queries"
licenses = ["Apache-2.0"]
authors = ["Scaratti Daniele aka lupodevelp"]
Expand Down
Loading