Conversation
Adds a command to pipe the required confirmation text to 'gleam publish' for versions below 1.0.0, enabling automated publishing in the release workflow.
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be preparing for a 1.0.0 release by updating the version number, but includes contradictory workflow changes that handle pre-1.0.0 version publishing.
- Version bumped from 0.1.0 to 1.0.0 in gleam.toml
- Release workflow modified to include logic for handling versions < 1.0.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gleam.toml | Version number updated to 1.0.0 |
| .github/workflows/release.yml | Added comments and piped input for publishing pre-1.0.0 versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # For versions < 1.0.0, gleam publish requires explicit confirmation | ||
| # We pipe the required text to accept publishing 0.x versions | ||
| echo "I am not using semantic versioning" | gleam publish --yes |
There was a problem hiding this comment.
The comment and piped input are intended for versions < 1.0.0, but the version in gleam.toml is being set to 1.0.0. This workflow change is unnecessary for 1.0.0 and later versions, as they follow semantic versioning and don't require the 'I am not using semantic versioning' confirmation. Either revert this workflow change or keep the version below 1.0.0.
| # For versions < 1.0.0, gleam publish requires explicit confirmation | |
| # We pipe the required text to accept publishing 0.x versions | |
| echo "I am not using semantic versioning" | gleam publish --yes | |
| gleam publish --yes |
This pull request prepares the project for its 1.0.0 release and updates the publishing workflow to streamline package publishing for future versions. The most significant changes are grouped below:
Versioning and Release Preparation:
1.0.0ingleam.toml, marking the first major release and indicating API stability.Publishing Workflow Improvements:
.github/workflows/release.ymlto handle pre-1.0.0 versions by piping the required confirmation text togleam publish, ensuring smoother automation for future releases.