Open
Conversation
added 26 commits
August 13, 2012 12:11
Also fix the util.getAppPath function that is used to find additional data files if kodos is run directly from the git checkout accordingly.
The use of os.system should be replaced by the means of the subprocess module. This also makes sure that any non zero exit status of make is fatal.
The .ui files are not used at runtime, so there is no need to install them.
The debug module is not used anywhere besides util.py and the variable `debug` from that module is initialized to `DEBUG_NONE` effectively disabling all debug related events in util.py anyway.
Formerly the code used the qApp imported from PyQt4.QtGui which also seems to work but it is not obviously clear why. It seems like the qApp there points to the right (the most recent created?) QApplication object. Hand a reference to our QApplication object to the `Kodos` class to make this explicit and more robust.
There is no QIconSet in Qt4. Simply remove the method RecentFiles.move since that this method is unused.
The PyQt4 bindings handle python booleans seamlessly. In fact, True and False are numeric values in python with the same values (isinstance(True, int) and True == 1).
This was referenced Dec 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, here's the next round of cleanups including packaging cleanups, replacing getopt with optparse, making use of the logging module, cleaning up the imports and fixing various problems found by pyflakes.