Migration to Python3 completed but still using PyQt4#10
Closed
sergiomb2 wants to merge 37 commits intoluksan:masterfrom
Closed
Migration to Python3 completed but still using PyQt4#10sergiomb2 wants to merge 37 commits intoluksan:masterfrom
sergiomb2 wants to merge 37 commits intoluksan:masterfrom
Conversation
…ense file), 0f0d6f6 (Add a copyright file), ef3ea6a (Use one central .gitignore) all others are revert to have teythoon branch is work much better | * f4af13a 2013-08-04 02:19 phobie Fix: three lines missed in the last commit | * 88c9e93 2013-08-04 01:22 phobie Remove PyQt v3 style wrapper classes Fix: implement missing helpHelpAction in the regex library | * ef3ea6a 2013-08-03 11:07 phobie Use one central .gitignore file Added ignores for qm files and some build dirs | * 937a5e6 2013-08-03 11:04 phobie Removed binary file from source (kodos_pl.qm) Remove unused ui file (resultsBA.ui) Bugfix for pylupdate4 to update all ts files (kodos.pro) | * 0f0d6f6 2013-08-03 10:26 phobie Add a copyright file to list all contributors | * 3ec49fe 2013-08-02 17:39 phobie simplify and unify PyQt4 module loading | * 2491196 2013-08-02 12:16 phobie Use relative imports for Kodos modules Fallback to pickle if cPickle is not available Address all pyflakes issues: * Avoid star imports * Replace unset variable qApp by QApplication * Do not set unused variables * Comment out unused and buggy RecentFiles.move() function | * 40b6f19 2013-08-01 15:11 phobie Implement PEPs: PEP 3101: format strings with format() instead of '%' PEP 3105: print as function instead of statement PEP 3110: exceptions with 'as' instead of ',' (With this change Kodos depends on Python >=2.6) | * 4725328 2013-07-31 18:22 phobie Add modelines (in vi, emacs and jEdit format) [see http://www.wireshark.org/tools/modelines.html] Seperate module imports (into built-in, installed and Kodos) Add separation lines | * f14090d 2013-07-30 18:56 phobie Use return in all functions. (Zen of Python: Explicit is better than implicit.) | * 6724664 2013-07-30 17:07 phobie Updated license file (fixed address and changed Library to Lesser when referencing to LGPL)
Also fix the util.getAppPath function that is used to find additional data files if kodos is run directly from the git checkout accordingly.
The use of os.system should be replaced by the means of the subprocess module. This also makes sure that any non zero exit status of make is fatal.
The .ui files are not used at runtime, so there is no need to install them.
The debug module is not used anywhere besides util.py and the variable `debug` from that module is initialized to `DEBUG_NONE` effectively disabling all debug related events in util.py anyway.
Formerly the code used the qApp imported from PyQt4.QtGui which also seems to work but it is not obviously clear why. It seems like the qApp there points to the right (the most recent created?) QApplication object. Hand a reference to our QApplication object to the `Kodos` class to make this explicit and more robust.
There is no QIconSet in Qt4. Simply remove the method RecentFiles.move since that this method is unused.
The PyQt4 bindings handle python booleans seamlessly. In fact, True and False are numeric values in python with the same values (isinstance(True, int) and True == 1).
This reverts commit 49ef051.
Bugfix kodos.pro, completes commmit 937a5e6
File "/usr/lib/python2.7/site-packages/kodos/urlDialog.py", line 39, in ok_slot
URLDialogBA.accept(self)
and minor fixes
Add -py3 to pyrcc4 Add --from-imports to pyuic4 Comment sed replace on translations/Makefile
sergiomb2
force-pushed
the
master
branch
2 times, most recently
from
278183b to
7f10e7b
Compare
sergiomb2
changed the title
Contributor
Author
|
Migration to Python3 completed, this is my tag v.2.5.2 https://github.com/sergiomb2/kodos/releases/tag/v2.5.2 I committed by accident commit 2c46b46 which is about Kodos-qt5 and was moved to the devel branch, the next force-pushed 278183b was a typo and now it is finnally corrected . |
sergiomb2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included here the PRs #7, #5 and #4 see https://github.com/sergiomb2/kodos/releases/tag/v2.5.1 .
After that, I convert kodos to python3 , It is working great on my box with Fedora 32 !
For you want check it out I have builds here : https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/package/kodos/