Skip to content

Split kodos#5

Open
teythoon wants to merge 7 commits intoluksan:masterfrom
teythoon:split_kodos
Open

Split kodos#5
teythoon wants to merge 7 commits intoluksan:masterfrom
teythoon:split_kodos

Conversation

@teythoon
Copy link
Collaborator

This patch (meant to be applied upon my recent pull request #4) splits the main kodos file.

@luksan
Copy link
Owner

luksan commented Aug 13, 2012

Do you have any numbers on the improvement in startup-time from splitting the main file into launcher and a module?

@teythoon
Copy link
Collaborator Author

No, mostly because it is hard to measure. The speedup results from more code being loaded from a .pyc file (this won't happen for the loader script thus it is best to keep it small and just do the command line parsing there). Note that speeding up the application startup is not the only reason for the split, it is also better from a methodological point of view.

@teythoon
Copy link
Collaborator Author

While performing subsequent cleanups I discovered an issue with this patchset (the help browser is broken). I'll send an updated patch set shortly.

@teythoon teythoon closed this Aug 19, 2012
@teythoon
Copy link
Collaborator Author

Um... my bad. The bug was introduced in another branch of mine for which I haven't sent a pull request yet. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants