Skip to content

Make LengthPrefixedBlock fields readonly #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaskabrt merged 2 commits into from
Jan 11, 2026
Merged

Make LengthPrefixedBlock fields readonly #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98553e1
Initial plan
Copilot Jan 11, 2026
13ed682
Make LengthPrefixedBlock fields readonly using primary constructor
Copilot Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/PbfLite/PbfBlockWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,7 @@ public LengthPrefixedBlock StartLengthPrefixedBlock(int estimatedBlockLength)
var contentPosition = lengthPosition + GetVarIntBytesCount((uint)estimatedBlockLength);
_position = contentPosition;

return new LengthPrefixedBlock
{
LengthPosition = lengthPosition,
ContentPosition = contentPosition
};
return new LengthPrefixedBlock(lengthPosition, contentPosition);
}

/// <summary>
Expand Down Expand Up @@ -195,7 +191,4 @@ public void FinalizeLengthPrefixedBlock(LengthPrefixedBlock block)
}
}

public record struct LengthPrefixedBlock {
public int LengthPosition;
public int ContentPosition;
}
public record struct LengthPrefixedBlock(int LengthPosition, int ContentPosition);