Make LengthPrefixedBlock fields readonly#18
Merged
lukaskabrt merged 2 commits intofeature/block-writingfrom Jan 11, 2026
Merged
Make LengthPrefixedBlock fields readonly#18lukaskabrt merged 2 commits intofeature/block-writingfrom
lukaskabrt merged 2 commits intofeature/block-writingfrom
Conversation
Co-authored-by: lukaskabrt <2894161+lukaskabrt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update serialization methods for nested classes in LengthPrefixedBlock
Make LengthPrefixedBlock fields readonly
Jan 11, 2026
lukaskabrt
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LengthPrefixedBlockstruct had mutable public fields that could be modified after creation, violating immutability best practices for value types used as tokens.Changes
LengthPrefixedBlockto use primary constructor syntax, making fields readonly by defaultBefore
After
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.