Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

fix: restore ready event signaling before server start to prevent timeouts#9

Merged
observerw merged 2 commits intofeat/cross-platform-supportfrom
copilot/sub-pr-7
Jan 13, 2026
Merged

fix: restore ready event signaling before server start to prevent timeouts#9
observerw merged 2 commits intofeat/cross-platform-supportfrom
copilot/sub-pr-7

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026

CI was timing out across all platforms. The ready event was being set inside the lifespan context manager after LSP client initialization, causing wait_ready() calls to timeout indefinitely.

Changes

  • Moved _ready_event.set() back to run() method, signaling immediately after connection info is available
  • Removed unnecessary _startup_error tracking and exception propagation logic
  • Simplified wait_ready() to basic event wait without error checks

The ready event now signals as soon as the server connection is established, allowing tests to proceed without waiting for full LSP client initialization.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…eouts

Co-authored-by: observerw <20661574+observerw@users.noreply.github.com>
Copilot AI changed the title [WIP] Add cross-platform support with TCP fallback fix: restore ready event signaling before server start to prevent timeouts Jan 12, 2026
Copilot AI requested a review from observerw January 12, 2026 17:23
@observerw observerw marked this pull request as ready for review January 13, 2026 06:30
@observerw observerw merged commit 111ed12 into feat/cross-platform-support Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants