Skip to content
This repository was archived by the owner on Jan 13, 2026. It is now read-only.

fix: restore ready event signaling before server start to prevent timeouts #9

Merged
observerw merged 2 commits into from
Jan 13, 2026
+10 −20
Merged

fix: restore ready event signaling before server start to prevent timeouts #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8025c00
Initial plan
Copilot Jan 12, 2026
8043320
fix: restore ready event signaling before server start to prevent tim…
Copilot Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions src/lsp_cli/manager/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class ManagedClient:
_logger_sink_id: int = field(init=False)
_port: int | None = field(init=False, default=None)
_ready_event: anyio.Event = field(init=False, factory=anyio.Event)
_startup_error: Exception | None = field(init=False, default=None)

def __attrs_post_init__(self) -> None:
self._deadline = anyio.current_time() + settings.idle_timeout
Expand All @@ -68,14 +67,8 @@ def id(self) -> str:
return get_client_id(self.target)

async def wait_ready(self) -> None:
"""Wait until the client is assigned a port/socket and ready to serve.

Raises:
Exception: If the client failed to start.
"""
"""Wait until the client is assigned a port/socket and ready to serve."""
await self._ready_event.wait()
if self._startup_error:
raise self._startup_error

@property
def conn(self) -> ConnectionInfo:
Expand Down Expand Up @@ -130,18 +123,12 @@ async def _serve(self) -> None:

@asynccontextmanager
async def lifespan(app: Litestar) -> AsyncGenerator[None]:
try:
async with self.target.client_cls(
workspace=self.target.project_path
) as client:
app.state.client = client
app.state.capabilities = Capabilities.build(client)
self._ready_event.set()
yield
except Exception as e:
self._startup_error = e
self._ready_event.set()
raise
async with self.target.client_cls(
workspace=self.target.project_path
) as client:
app.state.client = client
app.state.capabilities = Capabilities.build(client)
yield

def exception_handler(request: Request, exc: Exception) -> Response:
self._logger.exception("Unhandled exception in Litestar: {}", exc)
Expand Down Expand Up @@ -196,6 +183,9 @@ async def run(self) -> None:
await uds_path.unlink(missing_ok=True)
await uds_path.parent.mkdir(parents=True, exist_ok=True)

# Signal that connection info is available (port/socket path assigned)
self._ready_event.set()

self._logger.info(
"Starting managed client for project {} at {}",
self.target.project_path,
Expand Down