Skip to content

Apply PR review feedback: CI hardening, lint, URL fix, code cleanup #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lord63 merged 2 commits into from
Mar 21, 2026
+37 −5
Merged

Apply PR review feedback: CI hardening, lint, URL fix, code cleanup #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e5429
Initial plan
Copilot Mar 21, 2026
1ec45f1
Apply PR review: frozen sync, ruff lint, https URL, remove redundant …
Copilot Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: uv sync --dev
run: uv sync --dev --frozen

- name: Lint
run: uv run ruff check .
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff check . will lint the entire repo and should fail on existing violations (e.g., example/example_spin.py has an unused loop variable i that triggers F841). To keep CI green, either fix the existing violations (use _ instead of i / remove the variable) or configure ruff to exclude example/ (or ignore F841) via pyproject.toml or CI flags.

Suggested change
run: uv run ruff check .
run: uv run ruff check . --exclude example

Copilot uses AI. Check for mistakes.

- name: Run tests
run: uv run pytest -v test_pyspin.py
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ classifiers = [
]

[project.urls]
Homepage = "http://github.com/lord63/py-spin"
Homepage = "https://github.com/lord63/py-spin"

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

[dependency-groups]
dev = ["pytest>=8.0"]
dev = ["pytest>=8.0", "ruff"]

[tool.hatch.build.targets.wheel]
packages = ["pyspin"]
2 changes: 1 addition & 1 deletion pyspin/spin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _init_spin(self):
time.sleep(0.1)

def _spin_cursor(self):
print(str("\r{0} {1}").format(self.next(), self.words), end="")
print("\r{0} {1}".format(self.next(), self.words), end="")
sys.stdout.flush()

def __enter__(self):
Expand Down
31 changes: 30 additions & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading