Skip to content

Add logseq-phone-bridge plugin #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrimansoft wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add logseq-phone-bridge plugin #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5214,6 +5214,13 @@
"theme": true,
"id": "xypora-print-theme",
"addedAt": 1760749797000
},
{
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field "url" is inconsistent with the rest of the codebase. All other plugin entries use "repo" with just the repository identifier (e.g., "shrimansoft/logseq-upload-image"), not the full URL. Change "url" to "repo" and use the short form "shrimansoft/logseq-upload-image" instead of the full GitHub URL.

Suggested change
"url": "https://github.com/shrimansoft/logseq-upload-image",
"repo": "shrimansoft/logseq-upload-image",

Copilot uses AI. Check for mistakes.
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"
Comment on lines +5219 to +5222
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "title" field is missing. All other plugin entries in plugins.json include a "title" field for the display name. Add a "title" field with an appropriate display name for the plugin (e.g., "Phone Bridge" or "Logseq Phone Bridge").

Suggested change
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"
"title": "Logseq Phone Bridge",
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "addedAt" field is missing. All other plugin entries in plugins.json include an "addedAt" timestamp field (in milliseconds since epoch). Add this field with the current timestamp.

Suggested change
"author": "shrimansoft"
"author": "shrimansoft",
"addedAt": 1771294881025

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "icon" field is missing. While optional, most plugin entries include an icon field. Consider adding an "icon" field if the plugin repository contains an icon file.

Suggested change
"author": "shrimansoft"
"author": "shrimansoft",
"icon": "icon.png"

Copilot uses AI. Check for mistakes.
Comment on lines +5219 to +5222
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: This entry uses 4 spaces for indentation, while all other entries consistently use 6 spaces for the top-level fields within each plugin object. Adjust indentation to match the existing codebase convention.

Suggested change
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"

Copilot uses AI. Check for mistakes.
Comment on lines +5219 to +5222
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field ordering is inconsistent. The standard convention in this codebase is to order fields as: title, description, author, repo, icon, (optional fields like theme, effect, sponsors, supportsDB, supportsDBOnly), id, addedAt. Reorder the fields to match this convention.

Suggested change
"id": "logseq-phone-bridge",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft"
"description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).",
"author": "shrimansoft",
"url": "https://github.com/shrimansoft/logseq-upload-image",
"id": "logseq-phone-bridge"

Copilot uses AI. Check for mistakes.
}

Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace on line 5224. Remove the trailing whitespace to maintain consistency with the rest of the file.

Suggested change

Copilot uses AI. Check for mistakes.
]
}
}
Loading