Conversation
Added a new plugin for transferring images from phone to Logseq using WebRTC/SSE.
There was a problem hiding this comment.
Pull request overview
This pull request adds a new plugin called "logseq-phone-bridge" to the Logseq marketplace. The plugin enables users to transfer images from their phone to Logseq locally using WebRTC/SSE technology without requiring an internet connection.
Changes:
- Adds a new plugin entry for logseq-phone-bridge to the marketplace registry (plugins.json)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| { | ||
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", |
There was a problem hiding this comment.
The field "url" is inconsistent with the rest of the codebase. All other plugin entries use "repo" with just the repository identifier (e.g., "shrimansoft/logseq-upload-image"), not the full URL. Change "url" to "repo" and use the short form "shrimansoft/logseq-upload-image" instead of the full GitHub URL.
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "repo": "shrimansoft/logseq-upload-image", |
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", | ||
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" |
There was a problem hiding this comment.
The "title" field is missing. All other plugin entries in plugins.json include a "title" field for the display name. Add a "title" field with an appropriate display name for the plugin (e.g., "Phone Bridge" or "Logseq Phone Bridge").
| "id": "logseq-phone-bridge", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft" | |
| "title": "Logseq Phone Bridge", | |
| "id": "logseq-phone-bridge", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft" |
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", | ||
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" |
There was a problem hiding this comment.
The "addedAt" field is missing. All other plugin entries in plugins.json include an "addedAt" timestamp field (in milliseconds since epoch). Add this field with the current timestamp.
| "author": "shrimansoft" | |
| "author": "shrimansoft", | |
| "addedAt": 1771294881025 |
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", | ||
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" |
There was a problem hiding this comment.
The "icon" field is missing. While optional, most plugin entries include an icon field. Consider adding an "icon" field if the plugin repository contains an icon file.
| "author": "shrimansoft" | |
| "author": "shrimansoft", | |
| "icon": "icon.png" |
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", | ||
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" |
There was a problem hiding this comment.
Inconsistent indentation: This entry uses 4 spaces for indentation, while all other entries consistently use 6 spaces for the top-level fields within each plugin object. Adjust indentation to match the existing codebase convention.
| "id": "logseq-phone-bridge", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft" | |
| "id": "logseq-phone-bridge", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft" |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing whitespace on line 5224. Remove the trailing whitespace to maintain consistency with the rest of the file.
| "id": "logseq-phone-bridge", | ||
| "url": "https://github.com/shrimansoft/logseq-upload-image", | ||
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | ||
| "author": "shrimansoft" |
There was a problem hiding this comment.
Field ordering is inconsistent. The standard convention in this codebase is to order fields as: title, description, author, repo, icon, (optional fields like theme, effect, sponsors, supportsDB, supportsDBOnly), id, addedAt. Reorder the fields to match this convention.
| "id": "logseq-phone-bridge", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft" | |
| "description": "Transfer images from phone to Logseq locally via WebRTC/SSE (No Internet Required).", | |
| "author": "shrimansoft", | |
| "url": "https://github.com/shrimansoft/logseq-upload-image", | |
| "id": "logseq-phone-bridge" |
Added a new plugin for transferring images from phone to Logseq using WebRTC/SSE.
Submit a new Plugin to Marketplace
Plugin GitHub repo URL: https://github.com/shrimansoft/logseq-upload-image
GitHub releases checklist