Allow customization of data use terms agreement text#6149
Draft
theosanderson wants to merge 6 commits intomainfrom
Draft
Allow customization of data use terms agreement text#6149theosanderson wants to merge 6 commits intomainfrom
theosanderson wants to merge 6 commits intomainfrom
Conversation
… values.yaml Add a `dataUseTerms.agreementHtml` setting in values.yaml that allows overriding the "I agree to the data use terms." checkbox label in the download dialog with custom HTML. This enables linking to multiple different pages or customizing the agreement text per instance. The default value preserves the current behavior with a link to the data use terms page. https://claude.ai/code/session_013oJyL4K1RSVkBKLpEBa3DC
claude
bot
added
website
Contributor
|
This PR may be related to: #3674 (Genericise data use terms for other maintainers) |
This reverts commit 500ac06.
… error in DownloadDialog The agreementHtml property was placed outside the properties object in the dataUseTerms schema definition, causing invalid JSON. Also add eslint-disable for the __html key required by dangerouslySetInnerHTML. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove the agreementHtml setting from values.yaml so the fallback is used, and simplify the fallback text to plain "I agree to the data use terms." without a link. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for customizing the data use terms agreement checkbox label text in the download dialog through configuration. Previously, the text was hardcoded as "I agree to the data use terms" with a link to the terms page.
The changes allow administrators to provide custom HTML for the agreement label via the
dataUseTerms.agreementHtmlconfiguration option, enabling more flexible messaging while maintaining backward compatibility with a sensible default.Changes
dataUseTermsAgreementHtmlconfiguration property to website config schemaDownloadDialogcomponent to use custom HTML when provided, falling back to the default textgetDataUseTermsAgreementHtml()to retrieve the custom HTMLSearchFullUI→DownloadDialog)Configuration
The new configuration option is optional and located under
dataUseTerms.agreementHtml. When not provided, the component renders the default agreement text. The configuration accepts HTML strings, allowing for custom links and formatting.PR Checklist
https://claude.ai/code/session_013oJyL4K1RSVkBKLpEBa3DC
🚀 Preview: Add
previewlabel to enable