feat(website, config): create a customDisplay for reference with variant information#6133
feat(website, config): create a customDisplay for reference with variant information#6133anna-parker wants to merge 2 commits intomainfrom
Conversation
|
Claude finished @anna-parker's task in 2m 27s —— View job Code Review
The overall approach is clean. The One real bug to fix:
The test file covers the important cases well, but there's no test that would catch the above bug — see inline comment on the test file. |
website/src/components/SequenceDetailsPage/DataTableEntryValue.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/DataTableEntryValue.spec.tsx
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3674d37a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
website/src/components/SequenceDetailsPage/DataTableEntryValue.tsx
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 842956664f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
87788f6 to
96840fb
Compare
There was a problem hiding this comment.
Personally I don't find this intuitive - if I see
Closest reference: A (variant)
I would assume that the closest reference is a variant of A, rather than that this sequence is a variant. But it's not my area
There was a problem hiding this comment.
Is there a different display you would find more intuitive? Also tagging @rneher as he requested this. Perhaps closest reference should be changed? We could call it L segment lineage: A (variant) would that be clearer?
There was a problem hiding this comment.
I don't have a great instinct - but yes, I guess that would be clearer but then I'm not sure if that naming is actually accurate - would this use case be called a lineage in the cases we're interested in?
7d00c22 to
cdfda47
Compare
3325c51 to
b293a42
Compare
b293a42 to
6620987
Compare
This adds an additional custom display, similar to the custom display for length and completeness, but in this case for assigned reference and variant strain, where variant strain is a boolean based on the number of private mutations a sequence has - this is currently in use on the private virus preview and has been enabled for cchf multi-ref for testing purposes.
Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable