feat(integration-tests): add tests for uncovered UI features#5995
Draft
theosanderson-agent wants to merge 1 commit intomainfrom
Draft
feat(integration-tests): add tests for uncovered UI features#5995theosanderson-agent wants to merge 1 commit intomainfrom
theosanderson-agent wants to merge 1 commit intomainfrom
Conversation
…atures Add integration tests for features discovered through browser exploration that had no existing test coverage: API documentation page, 404 error pages, landing page organism statistics, footer navigation links, header accession quick-search, sequence detail page metadata sections, search table column sorting, Tools/link-out menu, and advanced search options modal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude
bot
added
e2e
Contributor
|
This PR adds 23 new integration tests covering previously untested UI features. The following open issues appear related to the work here and may be worth referencing or considering:
None of these issues appear to be directly resolved by this PR, but they represent related work in the integration test area. |
anna-parker
reviewed
Feb 24, 2026
| import { test } from '../../../fixtures/console-warnings.fixture'; | ||
| import { SearchPage } from '../../../pages/search.page'; | ||
|
|
||
| test.describe('Search table sorting', () => { |
Contributor
There was a problem hiding this comment.
I wonder if this could be flaky - can we wait for there to be multiple sequences? also potentially the first sequence will by chance be the earliest, maybe we should actually compare the date?
anna-parker
reviewed
Feb 24, 2026
| await searchPage.ebolaSudan(); | ||
|
|
||
| const rows = searchPage.getSequenceRows(); | ||
| await rows.first().waitFor(); |
Contributor
There was a problem hiding this comment.
I guess also here, should we ensure there are multiple sequences?
anna-parker
reviewed
Feb 24, 2026
Comment on lines
+20
to
+21
| .or(page.getByText(/does not exist/i)) | ||
| .or(page.getByText(/error/i)) |
Contributor
There was a problem hiding this comment.
Suggested change
| .or(page.getByText(/does not exist/i)) | |
| .or(page.getByText(/error/i)) |
anna-parker
reviewed
Feb 24, 2026
| test('should display error for non-existent sequence accession', async ({ page }) => { | ||
| await page.goto('/seq/LOC_NONEXISTENT.1'); | ||
|
|
||
| // The page may render with 200 but show an error message |
Contributor
There was a problem hiding this comment.
the page should render with 200 and the message:
anna-parker
reviewed
Feb 24, 2026
| test('should display error for non-existent sequence accession', async ({ page }) => { | ||
| await page.goto('/seq/LOC_NONEXISTENT.1'); | ||
|
|
||
| // The page may render with 200 but show an error message |
Contributor
There was a problem hiding this comment.
Suggested change
| // The page may render with 200 but show an error message | |
| // The page should render with 200 but show an error message |
anna-parker
reviewed
Feb 24, 2026
| await detailPage.goto(accessionVersion); | ||
|
|
||
| await expect(page.getByText('Sample details')).toBeVisible(); | ||
| await expect(page.getByText('Collection date')).toBeVisible(); |
Contributor
There was a problem hiding this comment.
this might also flake as certain INSDC sequences do not have a collection date
anna-parker
approved these changes
Feb 24, 2026
Contributor
anna-parker
left a comment
anna-parker
left a comment
There was a problem hiding this comment.
looks good! I added a couple comments of where I think the tests could get flaky and should be modified but I have still approved as I think this is an overall improvement :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New test coverage areas:
api-documentation-page.spec.tserror-pages.spec.tslanding-page-statistics.spec.tsfooter-links.spec.tsheader-accession-search.dependent.spec.tssequence-detail-metadata.dependent.spec.tssearch/table-sorting.dependent.spec.tssearch/tools-link-out.dependent.spec.tssearch/advanced-options.dependent.spec.tsTest plan
BROWSER=chromium npx playwright testagainst local k3dnpm run format)🤖 Generated with Claude Code
🚀 Preview: Add
previewlabel to enable