feat(website): edit page - do not include fasta description in metadata field fastaIds#5629
Merged
anna-parker merged 14 commits intoedit-page-anyafrom Dec 5, 2025
Merged
feat(website): edit page - do not include fasta description in metadata field fastaIds#5629anna-parker merged 14 commits intoedit-page-anyafrom
fastaIds#5629anna-parker merged 14 commits intoedit-page-anyafrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
anna-parker
requested review from
corneliusroemer,
fengelniederhammer and
theosanderson
anna-parker
changed the title
anna-parker
changed the title
fastaIds when generated by website edit page
anna-parker
force-pushed
the
edit-page-anya
branch
from
bce2b8a to
2213cec
Compare
anna-parker
force-pushed
the
fastaHeader
branch
from
2b67cb7 to
644b3c7
Compare
anna-parker
changed the title
fastaIds when generated by website edit pagefastaIds
anna-parker
force-pushed
the
fastaHeader
branch
from
2df8bfe to
e1a37a4
Compare
| fastaHeader ??= value == null ? null : key; // Ensure fastaHeader is never null if a sequence exists | ||
| if (this.editableSequenceFiles.some((seq) => seq.fastaHeader === fastaHeader)) { | ||
| toast.error(`A sequence with the fastaHeader ${fastaHeader} already exists.`); | ||
| if (this.editableSequenceFiles.some((seq) => getFastaId(seq.fastaHeader) === getFastaId(fastaHeader))) { |
Contributor
There was a problem hiding this comment.
Should we maybe just save only the ID straightaway when loading the sequence into EditableSequence? Then we don't need to do all these conversions later on?
Contributor
Author
There was a problem hiding this comment.
Im not sure if this conversion is complicated enough to store the fastaId as well - but Id be up for adding it if you think it makes the code cleaner!
anna-parker
commented
Dec 5, 2025
Contributor
Author
|
@fengelniederhammer I rerequested review as I feel like I have now changed a substantial part of the PR - lol |
fengelniederhammer
approved these changes
Dec 5, 2025
corneliusroemer
approved these changes
Dec 5, 2025
Co-authored-by: Fabian Engelniederhammer <92720311+fengelniederhammer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5627
The
fastaIdsobject should contain a space separated list of fasta IDs. The website was constructingfastaIdsfor submissions via the edit page by concatenating full fasta headers of the form>fastaId description(and removing>) - but this lead to the backend thinking the description was another fastaId.Also adds a description to multiple fasta files in the integration tests to ensure in future such an issue cannot be missed
Screenshot
PR Checklist
🚀 Preview: https://fastaheader.loculus.org