-
Notifications
You must be signed in to change notification settings - Fork 1
Zap Receipts #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zap Receipts #128
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,20 @@ CHARTS=( | |
|
|
||
| REGISTRY="oci://ghcr.io/brh28" | ||
|
|
||
| # Check if a specific chart was provided as argument | ||
| if [ -n "$1" ]; then | ||
| # Validate that the provided chart exists in CHARTS array | ||
| if [[ " ${CHARTS[@]} " =~ " $1 " ]]; then | ||
| CHARTS=("$1") | ||
| echo "Packaging single chart: $1" | ||
| else | ||
| echo "Error: Chart '$1' not found in available charts: ${CHARTS[@]}" | ||
| exit 1 | ||
| fi | ||
| else | ||
| echo "Packaging all charts..." | ||
| fi | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean to leave this code? it seems like debug logging.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, added intentionally. It updates the Charts var based on cli input, allowing us to build a single package, rather than all |
||
| for chart in "${CHARTS[@]}"; do | ||
| echo "Processing $chart..." | ||
| helm dependency update "charts/$chart" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will removing the versioning make it look for the "latest" by default?
I think we should be ok if the digest overrides all else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it'll look for the digest by default.
tag:would be it's own field